Skip to content

Make Service count reflect the real number - #353

Merged
Bohreromir merged 2 commits into
mainfrom
feat/dashboard-service-count
Oct 20, 2026
Merged

Bohreromir merged 2 commits into
mainfrom
feat/dashboard-service-count

Conversation

@Bohreromir

Copy link
Copy Markdown
Member

No description provided.

@Bohreromir Bohreromir self-assigned this Oct 6, 2026
@Bohreromir Bohreromir moved this to Development: Waiting for Review in Stackable Engineering Oct 6, 2026
@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 64.88% 8534 / 13152
🔵 Statements 63.93% 11446 / 17903
🔵 Functions 66.38% 2721 / 4099
🔵 Branches 54.97% 4919 / 8948
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/routes/(app)/+page.server.ts 100% 100% 100% 100%
src/routes/(app)/+page.svelte 80.51% 100% 100% 100% 5-108
Generated in workflow #1111 for commit b68b035 by the Vitest Coverage Report Action

@lfrancke

lfrancke commented Oct 6, 2026

Copy link
Copy Markdown
Member

I'll let others weigh in but do I read this correctly that stuff like the Trino Query UI is now counted even though it might not even be used?

@Bohreromir

Copy link
Copy Markdown
Member Author

I read it as usable services.
If Trino is not configured by the env vars it still shows up and lets the user edit connection settings.
The same as for the s3 browser, where the user can add connections.
If we later add real service discovery this has to be adjusted.

@lfrancke lfrancke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still a bit on the fence about this but we can always change it later.

@lfrancke lfrancke moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 20, 2026
@Bohreromir
Bohreromir merged commit 58722d5 into main Oct 20, 2026
14 of 15 checks passed
@Bohreromir
Bohreromir deleted the feat/dashboard-service-count branch October 20, 2026 11:05
@Bohreromir Bohreromir moved this from Development: In Review to Development: Done in Stackable Engineering Oct 20, 2026
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants