Repository navigation
stubtest: expand Unpack[TypedDict] kwargs in overloads - #22239
Open
NavpreetSSidhu wants to merge 1 commit into
Open
NavpreetSSidhu wants to merge 1 commit into
NavpreetSSidhu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22238
#21024 made stubtest expand
**kwargs: Unpack[TypedDict]into keyword arguments, but only inSignature.from_funcitem. Overloads go throughfrom_overloadedfuncdef, which reads each item's raw arguments, so they still got a plain**kwargsand stubtest reported every key as missing.This moves the expansion into
expand_unpacked_kwargs()and applies it to plain functions and to each overload item. The merged overload signature then picks up the keys like any other keyword arguments, so a key only present in some overloads is treated as optional.Added two overload cases to
test_kwargs_unpack_typeddict: one that matches the runtime and one where the runtime has a different keyword. The new test fails on master and passes with this change.