Skip to content

gh-143632: Fix the musl check for PR_SET_VMA_ANON_NAME - #159886

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:gh-159885-musl-prctl
Oct 20, 2026
Merged

serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:gh-159885-musl-prctl

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Match on the host triplet instead of the unset $ac_cv_libc. configure regenerated with autoconf 2.72.

Verified: glibc x86_64 unchanged (check runs, macro defined), musl x86_64 unchanged (skipped), musl i686 now builds without ac_cv_have_decl_PR_SET_VMA_ANON_NAME=no.

Matching the triplet rather than __GLIBC__ keeps the check enabled on Android/bionic, where the headers do not clash.

🤖 Generated with Claude Code

The guard added by pythongh-143730 tested $ac_cv_libc, which is never set, so the
check always ran and the build could fail on the struct prctl_mm_map
redefinition it was meant to avoid.  Match on the host triplet instead.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
@serhiy-storchaka serhiy-storchaka changed the title gh-159885: Fix the musl check for PR_SET_VMA_ANON_NAME gh-143632: Fix the musl check for PR_SET_VMA_ANON_NAME Oct 20, 2026

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@serhiy-storchaka
serhiy-storchaka merged commit f37e821 into python:main Oct 20, 2026
95 of 98 checks passed
@serhiy-storchaka
serhiy-storchaka deleted the gh-159885-musl-prctl branch October 20, 2026 17:29
@serhiy-storchaka serhiy-storchaka added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Oct 20, 2026
@miss-islington-app

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker f37e82139a24c4f1bd84c7d9111f44719b94fff5 3.14

@bedevere-app

bedevere-app Bot commented Oct 20, 2026

Copy link
Copy Markdown

GH-159919 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Oct 20, 2026
@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.14 bugs and security fixes label Oct 20, 2026
serhiy-storchaka added a commit that referenced this pull request Oct 20, 2026
) (GH-159919)

The guard added by gh-143730 tested $ac_cv_libc, which is never set, so the
check always ran and the build could fail on the struct prctl_mm_map
redefinition it was meant to avoid.  Match on the host triplet instead.
(cherry picked from commit f37e821)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants