Skip to content

gh-60729: Add missing versionadded/versionchanged tags to wave module - #159644

Open
bdieterm wants to merge 1 commit into
python:mainfrom
bdieterm:update-wave-docs
Open

gh-60729: Add missing versionadded/versionchanged tags to wave module#159644
bdieterm wants to merge 1 commit into
python:mainfrom
bdieterm:update-wave-docs

Conversation

@bdieterm

@bdieterm bdieterm commented Oct 17, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown

This change adds the missing versionadded info to the docs of method setformat in the wave module.

related:

versionadded tags added only for getformat
#153897

introduction of getformat and setformat in the wave module
#145931

@python-cla-bot

python-cla-bot Bot commented Oct 17, 2026 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 17, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Oct 17, 2026
@read-the-docs-community

read-the-docs-community Bot commented Oct 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #35279763 | 📁 Comparing bf66fd3 against main (18f3a71)

  🔍 Preview build  

23 files changed · ± 23 modified

± Modified

@picnixz picnixz changed the title Add versionadded tag to wave module setformat method gh-60729: Add versionadded tag to wave.setformat method Oct 19, 2026
@bedevere-app bedevere-app Bot added the type-feature A feature request or enhancement label Oct 19, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Oct 19, 2026
Closed
@aisk

aisk commented Oct 20, 2026

Copy link
Copy Markdown
Member

WAVE_FORMAT_IEEE_FLOAT is added in the same PR https://github.com/python/cpython/pull/145931/changes, so please also add a versionadded directive for it.

And the setparams method adds support for 7 items tuple, so we should add a versionchanged directive for it.

@aisk aisk removed the type-feature A feature request or enhancement label Oct 20, 2026
@bedevere-app bedevere-app Bot added the type-feature A feature request or enhancement label Oct 20, 2026
@bdieterm bdieterm changed the title gh-60729: Add versionadded tag to wave.setformat method gh-60729: Add missing versionadded/versionchanged tags to wave module Oct 20, 2026
@bdieterm

bdieterm commented Oct 20, 2026

Copy link
Copy Markdown
Author

@aisk
done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting review docs Documentation in the Doc dir skip news type-feature A feature request or enhancement

Projects

Docs PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bdieterm @aisk