Repository navigation
feat(hub): add sidebar feedback link - #27
Merged
Merged
Conversation
Co-authored-by: Copilot App <[email protected]> Copilot-Session: 6fbf160c-eede-4e16-adc5-29526ef4b5ee
There was a problem hiding this comment.
🟡 Changes recommended
The updated navigation test skips internal links missing their in-app navigation attribute, weakening existing regression coverage.
1 open issue
What changed in this PR
Adds Feedback to Hub’s shared sidebar so signed-in users can share feedback without replacing their current workspace.
Changes:
- Adds a heart-in-speech-bubble icon and collapsed-sidebar tooltip.
- Supports external links opening safely in a new tab.
- Updates translated page data, fixtures, and navigation tests.
| File | Description |
|---|---|
| hub/test/views/hub_administration_navigation_test.rb | Checks Feedback availability without Hub administration. |
| hub/config/locales/gallery.en.yml | Adds the Feedback label. |
| hub/app/views/shared/_hub_administration_navigation.json.props | Emits the translated label. |
| hub/app/javascript/storybook/fixtures/authenticated-header.ts | Updates shared story data. |
| hub/app/javascript/pages/repositories-show-page/index.test.tsx | Updates repository-page test data. |
| hub/app/javascript/pages/prototypes-show-page/index.test.tsx | Updates prototype-page test data. |
| hub/app/javascript/pages/new-prototype-page/index.test.tsx | Updates creation-page test data. |
| hub/app/javascript/features/repository-navigation/index.test.tsx | Checks Feedback placement and external-link attributes. |
| hub/app/javascript/components/workspace-navigation/types.ts | Requires the Feedback label. |
| hub/app/javascript/components/workspace-navigation/index.tsx | Renders Feedback and its collapsed tooltip. |
| hub/app/javascript/components/repository-navigation-item/index.tsx | Adds external-link support. |
Review effort: Max
Co-authored-by: Copilot App <[email protected]> Copilot-Session: 6fbf160c-eede-4e16-adc5-29526ef4b5ee
nshki
approved these changes
Oct 19, 2026
nshki
left a comment
nshki
left a comment
Contributor
There was a problem hiding this comment.
Approving with a couple minor comments. Thanks, @lukasoppermann!
Co-authored-by: Copilot App <[email protected]> Copilot-Session: 6fbf160c-eede-4e16-adc5-29526ef4b5ee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Hub users need a clear way to share feedback without leaving their current workspace.
What changes
Adds a Feedback link to the shared sidebar footer for all signed-in users. It uses a custom speech-bubble icon with a heart, opens the feedback destination in a new tab, and remains available when the sidebar is collapsed.