Repository navigation
build(deps): combine age-eligible Dependabot updates - #12
Merged
Merged
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
JSON 3 changes parsing and serialization defaults, and Hub compatibility still needs dependency-backed integration verification.
0 open findings
What changed in this PR
Combines age-eligible Dependabot updates across CI, Hub, and the starter, while excluding Hub’s Vite update.
Changes:
- Update Node setup action pins and Hub/starter dependencies.
- Remove duplicate response fields for JSON 3 compatibility.
- Adjust existing tests for Primer’s tooltip delay.
| File | Description |
|---|---|
| starter/package.json | Update Router, history, Jest DOM, and Vite. |
| starter/package-lock.json | Lock updated starter dependencies. |
| hub/package.json | Update Primer Brand. |
| hub/package-lock.json | Lock Primer Brand 0.78.0. |
| hub/Gemfile.lock | Lock JSON 3.0.2. |
| hub/Gemfile | Allow JSON 3 releases. |
| hub/app/views/github_apps/_configuration.json.props | Remove duplicate administrator fields. |
| hub/app/javascript/features/prototype-canvas-share-links/index.test.tsx | Await tooltip display. |
| hub/app/javascript/components/prototype-canvas-toolbar/index.test.tsx | Await tooltip display. |
| .github/workflows/starter-ci.yml | Update Node setup action pin. |
| .github/workflows/learning-ci.yml | Update Node setup action pin. |
| .github/workflows/hub-ci.yml | Update Node setup action pins. |
| .github/workflows/actions-ci.yml | Update Node setup action pin. |
Files not reviewed (2)
- hub/package-lock.json: Generated file
- starter/package-lock.json: Generated file
🧠 Review effort: Max
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Bring the eligible Dependabot updates together so they can be reviewed and landed as one maintenance change. This replaces #1, #2, #3, #5, #6, #7, and #8. The Hub Vite update in #4 stays out because its dependency-age check failed.
What changes
Updates the Node setup action and Hub's JSON and Primer Brand dependencies. The starter updates TanStack Router and its matching history package together, along with Jest DOM and Vite.
Removes duplicate response fields that JSON 3 now rejects. Adjusts existing tooltip tests for Primer's hover delay and rebuilds the bundled canvas assets.