Repository navigation
Upgrade promql-engine and Thanos - #7889
Merged
danielblando merged 1 commit intoOct 20, 2026
Merged
danielblando merged 1 commit into
danielblando merged 1 commit into
Conversation
Signed-off-by: Paurush Garg <[email protected]>
PaurushGarg
force-pushed
the
bump/promql-engine-thanos-update
branch
from
October 20, 2026 21:22
eb4bf9c to
caaf354
Compare
PaurushGarg
marked this pull request as ready for review
October 20, 2026 21:23
danielblando
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Bumps two dependencies:
promql-engineto7157e606efa6(currentmain).thanostodd67d9cc81c3, picking upto query: lazy chunk iterator creation with reuse in chunkSeriesIterator thanos-io/thanos#9055.Both pin query-path changes that allocate selector iterators, ring buffers and chunk iterators lazily and release them once a series is exhausted.
One source change was required by the Thanos bump.
pool.Pool[T]interface addedUsedBytes()andMaxBytes(), andstoregateway.chunkBytesPoolwrapspool.BucketedPool[byte]as a named field, so it no longer satisfied theinterface.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags