Repository navigation
Conversation
…tamp parser The year was computed as tm_year + 1900, which can overflow int (e.g. with %s), and passed to date::year, which holds 16 bits, so out-of-range years gave wrong timestamps. Compute the year in 64 bits and reject it if date::year cannot hold it. Drafted by Claude Code (an AI agent) and reviewed & approved by pearu.
|
Thanks for opening a pull request! This pull request has been automatically closed because you currently have 4 open pull requests, which is more than the limit of 3. Due to the increase in pull requests opened by AI bots, and in order to keep the review queue manageable, Apache Arrow limits contributors without repository access to at most 3 concurrently open pull requests. This helps make sure each pull request gets the attention it needs and that work in progress does not go stale. Once one of your other open pull requests has been merged or closed, you are welcome to reopen this one. See also: |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The parser computed the year as
tm_year + 1900, which can overflowint(e.g. with%s), and passed it todate::year, which holds 16 bits, so a year out of range gave a wrong timestamp.What changes are included in this PR?
The year is computed in 64 bits and rejected if
date::yearcannot hold it.Are these changes tested?
Yes,
TimestampParser.StrptimeYearOutOfRangecovers a year that wraps around and one wheretm_year + 1900overflowsint. It needs%sand is skipped wherestrptimedoes not parse%sinto 64 bits (e.g. on Windows).Are there any user-facing changes?
Values whose year does not fit in 16 bits no longer parse with
strptimeformats.AI usage disclosure
Developed with AI assistance (Claude Code): the fix, the test and this description were AI-generated under my direction and reviewed line by line by me. I own and can debug these changes. No copyrighted material is included.