Repository navigation
Show the valid values in the target_session_attrs error - #1396
Open
spicysharkco wants to merge 2 commits into
Open
spicysharkco wants to merge 2 commits into
spicysharkco wants to merge 2 commits into
Conversation
The message formatted the unbound SessionAttribute.__members__.values method, so it printed "<built-in method values of mappingproxy object>" instead of the accepted values.
The pattern matched any list that starts with any and ends with read-only, so a message that dropped or reordered values passed.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An invalid
target_session_attrs(for example?target_session_attrs=bogusin the DSN) raisesClientConfigurationErrorwith this message:The format call passes
SessionAttribute.__members__.valueswithout calling it. The change lists the enum values instead, so the message reads... one of ['any', 'primary', 'standby', 'prefer-standby', 'read-write', 'read-only'], got 'bogus'.Tested with a new
target_session_attrs_invalidrow inTestConnectParams, which checks the whole message, values in order, and fails without the change and passes with it. flake8 is clean.